DirectXMath Comment does not match with actual code?

Comment does not match with actual code?

Open zznewclear13 opened this issue 2 years ago • 1 comments

Our left handed perspective matrix should be like this:

$\begin{bmatrix}\frac{1}{tan(\frac{fovy}{2}) \cdot \frac{x}{y}} & 0 & 0 & 0 \\0 & \frac{1}{tan(\frac{fovy}{2})} & 0 & 0 \\0 & 0 & \frac{far}{far - near} & 1 \\0 & 0 & -\frac{far \cdot near}{far - near} & 0 \\\end{bmatrix}$

But the comments in DirectXMathMatrix.inl#L2518-L2521 seem to indicate the projection matrix is:

$\begin{bmatrix}\frac{1}{tan(\frac{fovy}{2})} & 0 & 0 & 0 \\0 & \frac{1}{tan(\frac{fovy}{2}) \cdot \frac{x}{y}} & 0 & 0 \\0 & 0 & \frac{far}{far - near} & 1 \\0 & 0 & -\frac{far \cdot near}{far - near} & 0 \\\end{bmatrix}$

Jan 25 '22 07:01 zznewclear13

The comments do look a little out of place...

Jan 31 '22 21:01 walbourn

Fixed https://github.com/microsoft/DirectXMath/commit/0fc79cd30994230b4d59ed0397247be23bfa7602

Nov 09 '22 23:11 walbourn

DirectXMath DirectXMath copied to clipboard

Comment does not match with actual code?

DirectXMath
DirectXMath copied to clipboard