Detours icon indicating copy to clipboard operation
Detours copied to clipboard

simple error with function "detour_skip_jmp" by Hook System function on Windows x64

Open JohnWins opened this issue 6 years ago • 2 comments

hi, function "detour_skip_jmp" does work for x86 api hook routine, but not ok for x64. detours will not detect the inner function is a import vector or something after a long jmp. So it does fail when hook a x64 function on that condition.

But also come up with a small patch for detour_skip_jmp. https://cdn1.imggmi.com/uploads/2019/10/24/8a2798e183931867e343354ff3c746bd-full.png

x86_asm_code: https://cdn1.imggmi.com/uploads/2019/10/24/7dfbcfd5408c4a327b871648f9cc3709-full.png

x64_asm_code: https://cdn1.imggmi.com/uploads/2019/10/24/c8d92586582d0bc4b45e107f769ff9a6-full.png

JohnWins avatar Oct 24 '19 03:10 JohnWins

Hey @JohnWins, would you mind submitting a PR to fix the issue you found?

The links are all dead at this point 😞.

bgianfo avatar Aug 27 '20 07:08 bgianfo

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days.