Detours icon indicating copy to clipboard operation
Detours copied to clipboard

Enable control over import ordinal and add DetourUpdateDllWithDll

Open JohnMcPMS opened this issue 2 years ago • 1 comments

This change is largely about being able to control the import ordinal set in UPDATE_IMPORTS_XX, but also includes a new function DetourUpdateDllWithDll which is similar to DetourUpdateProcessWithDllEx.

Additional parameters for DetourUpdateProcessWithDllEx are added to make DetourUpdateProcessWithDllEx2. I wasn't sure what the natural next name was for post-Ex (I assume it isn't ExEx). Maybe it should be DetourUpdateProcessWithDllAndOrdinals instead?

Microsoft Reviewers: Open in CodeFlow

JohnMcPMS avatar Apr 22 '22 18:04 JohnMcPMS

Needs review.

JohnMcPMS avatar Sep 15 '22 23:09 JohnMcPMS

Windows has started with "2" and "3", and perhaps, taking parameters in structs. Though the struct thing..is still wierd -- size or flags, etc.? Years ago "we" formulated the general case is that you need maybe like: flags in flags honored out flags ignored out (honored+ignored=in for success)

or perhaps flags required in flags ignorable in flags honored out (of the ignorable ones)

But even this might not suffice -- imagine a caller wants to probe what flags are understood. Perhaps a simpler and more complete design: FooGetKnownFlags() and then caller can decide, and pass no more than that.

jaykrell avatar Oct 02 '22 10:10 jaykrell