DeepSpeed icon indicating copy to clipboard operation
DeepSpeed copied to clipboard

Fix pipline dataloader when batch elements contain tuple

Open ghosthamlet opened this issue 4 years ago • 5 comments

ghosthamlet avatar Dec 01 '20 04:12 ghosthamlet

lgtm!

ShadenSmith avatar Dec 02 '20 19:12 ShadenSmith

Hi @jeffra, merge failed for test_pipe.py line 246, in _helper:

    assert rel_diff(base_avg, test_avg) < 0.03
AssertionError: assert 0.03816467364302331 < 0.03
 +  where 0.03816467364302331 = rel_diff(1.8875272107124328, 1.8154903507232667)

what can I do about it? it seems like not related to my simple commit.

ghosthamlet avatar Dec 03 '20 01:12 ghosthamlet

Hi @jeffra, merge failed for test_pipe.py line 246, in _helper:

    assert rel_diff(base_avg, test_avg) < 0.03
AssertionError: assert 0.03816467364302331 < 0.03
 +  where 0.03816467364302331 = rel_diff(1.8875272107124328, 1.8154903507232667)

what can I do about it? it seems like not related to my simple commit.

Yeah, this is pretty strange actually. I was just talking with @ShadenSmith about this as well. We need to investigate further since this shouldn't have anything to do with your PR changes.

jeffra avatar Dec 03 '20 02:12 jeffra

Ok, thanks.

ghosthamlet avatar Dec 04 '20 08:12 ghosthamlet

Can one of the admins verify this patch?

rocm-mici avatar Jun 09 '22 20:06 rocm-mici