DeepSpeed icon indicating copy to clipboard operation
DeepSpeed copied to clipboard

Enhance testing: Skip fused_optimizer tests if not supported.

Open vshekhawat-hlab opened this issue 1 year ago • 3 comments

Enhance testing: Skip fused_optimizer tests if not supported.

Added condition check to skip fused_optimizer tests if FusedAdam and FusedLamb are not supported by the accelerator. This enhancement ensures that the tests are appropriately skipped when the hardware configuration does not support these optimizers, preventing potential issues.

Details:

  • Introduced a condition check to determine support for FusedAdam and FusedLamb.
  • If not supported, fused_optimizer tests are skipped to improve test reliability.
  • Improved compatibility and stability across different hardware configurations.

vshekhawat-hlab avatar Feb 19 '24 12:02 vshekhawat-hlab

Sorry @vshekhawat-hlab - looks like we have merge conflicts with another PR, could you fix the merge conflicts and we can merge this? Thanks!

loadams avatar Mar 12 '24 23:03 loadams

@vshekhawat-hlab - could you resolve the merge conflicts on this PR?

loadams avatar Mar 28 '24 18:03 loadams

@vshekhawat-hlab - could you resolve the merge conflicts on this PR?

@loadams,

Can you please check it again.

vshekhawat-hlab avatar May 10 '24 06:05 vshekhawat-hlab