DeepSpeed icon indicating copy to clipboard operation
DeepSpeed copied to clipboard
verified publisher icon microsoft

Support Triton 2.2+

Open loadams opened this issue 1 year ago • 4 comments

loadams avatar Jan 11 '24 17:01 loadams

Hi, may I know this upgrading triton will also adjust triton kernels? https://github.com/microsoft/DeepSpeed/issues/4857

Thanks!

YizhouZ avatar Jan 12 '24 07:01 YizhouZ

Hi, may I know this upgrading triton will also adjust triton kernels? #4857

Thanks!

Hi @YizhouZ - the main goal here was just to add what is needed to fix our nv-inference tests (currently failing above) when using the newly published triton 2.2. For now we have pinned to 2.1 but this effort is to allow us to use 2.2, I probably won't adjust the kernels in this PR as well.

loadams avatar Jan 12 '24 16:01 loadams

Hi, may I know this upgrading triton will also adjust triton kernels? #4857 Thanks!

Hi @YizhouZ - the main goal here was just to add what is needed to fix our nv-inference tests (currently failing above) when using the newly published triton 2.2. For now we have pinned to 2.1 but this effort is to allow us to use 2.2, I probably won't adjust the kernels in this PR as well.

Understood. May I know if there is any plan to upgrade kernel for triton-2.2?

YizhouZ avatar Jan 15 '24 06:01 YizhouZ

It would be worth to manually run and to check the following pytests in deepspeed with the latest 2.2 triton image

stephen-youn avatar Feb 21 '24 19:02 stephen-youn