DeepSpeed icon indicating copy to clipboard operation
DeepSpeed copied to clipboard

[BUG] Parameter name of `DeepSpeedCPUAdam` optimizer

Open mypydl opened this issue 2 years ago • 1 comments

Describe the bug The name of the first parameter of DeepSpeedCPUAdam is different from that of other optimizers. It's model_params. But in the other optimizers, they are all params. When I pass parameters with keywords, it causes trouble. I have to change the key to use DeepSpeedCPUAdam.

Expected behavior Replace model_params with params.

mypydl avatar Jul 08 '23 12:07 mypydl

@mypydl - this also looks to be set for cpu_adagrad and cpu_lion.

loadams avatar Jul 10 '23 17:07 loadams