DeepSpeed icon indicating copy to clipboard operation
DeepSpeed copied to clipboard

some fix in flops_profiler

Open lucasleesw opened this issue 2 years ago • 5 comments

  1. Tensor.bmm missed in _patch_tensor_methods function
  2. missed funtions in _reload_functionals and _reload_tensor_methods functions
  3. torch.mm and torch.Tensor.mm will have same __name__ in wrapFunc, my suggustion is use __str__ instead.
  4. add torch.baddbmm

lucasleesw avatar Jul 05 '22 00:07 lucasleesw

CLA assistant check
All CLA requirements met.

@cli99

lucasleesw avatar Jul 09 '22 06:07 lucasleesw

@lucasleesw, thanks for the PR. Can you please use this to resolve the formatting issues

tjruwase avatar Jul 20 '22 17:07 tjruwase

Hi @lucasleesw , thanks for the PR. Is there a reason you use str instead of str()?

cli99 avatar Jul 20 '22 19:07 cli99

Hi @lucasleesw , thanks for the PR. Is there a reason you use str instead of str()?

Nothing specific, just choose another attribute instead of __name__.

lucasleesw avatar Jul 21 '22 00:07 lucasleesw