DeepSpeed icon indicating copy to clipboard operation
DeepSpeed copied to clipboard
verified publisher icon microsoft

fixing the dataloader original len issue

Open tomekrut opened this issue 5 years ago • 5 comments

This is related to issue https://github.com/microsoft/DeepSpeed/issues/176

tomekrut avatar Mar 31 '20 12:03 tomekrut

CLA assistant check
All CLA requirements met.

msftclas avatar Mar 31 '20 12:03 msftclas

Thanks! This is looks great. Can you please add some unit tests? To cover

  1. Batch mode
  2. Non-batch mode
  3. Multiple epochs

You can refer to tests/unit for examples of unit tests and this guide.

tjruwase avatar Mar 31 '20 17:03 tjruwase

@tomekrut are you able to sign the contributor license agreement? Would love to merge your contribution soon! :)

jeffra avatar May 05 '20 22:05 jeffra

@tomekrut are you able to sign the contributor license agreement? Would love to merge your contribution soon! :)

Hi @jeffra - are you ok with that? Do you write unit test for things like that as well? If so, I can look at it but most likely Friday / Monday.

tomekrut avatar May 06 '20 14:05 tomekrut

Can one of the admins verify this patch?

rocm-mici avatar Jun 09 '22 20:06 rocm-mici