DeepSpeed icon indicating copy to clipboard operation
DeepSpeed copied to clipboard

Published 20 hours ago • verified publisher icon microsoft

fix dataloder len

Open roywei opened this issue 4 years ago • 6 comments

fix #1390

roywei avatar Sep 23 '21 04:09 roywei

@roywei, thanks for this PR. Can you please add some unit tests? An appropriate location would be tests/unit/test_data.py

tjruwase avatar Sep 23 '21 17:09 tjruwase

@roywei, can you please address formatting issues using instructions here? Thanks.

tjruwase avatar Sep 23 '21 18:09 tjruwase

@tjruwase Thanks for the review! will add test and reformat later today.

roywei avatar Sep 23 '21 20:09 roywei

@roywei, just wanted to check if you able to finish this PR? Thank!

tjruwase avatar Nov 05 '21 17:11 tjruwase

@tjruwase Sorry I totally forgot about this. I merged some tests from @junxu with test (Thanks to @junxu !!) It should be good now.

roywei avatar Jan 28 '22 23:01 roywei

Can one of the admins verify this patch?

rocm-mici avatar Jun 09 '22 20:06 rocm-mici

Stale, feel free to re-open if this is still required.

jeffra avatar Mar 24 '23 03:03 jeffra