microsoft
Fix collisions in indirect sqlproj dependencies for separate databases
Issue
When using transitive project references in SQL projects (where Project A references Project B, which references Project C), database variables were not properly preserved between projects. This caused name collisions when multiple projects contained objects with the same name, even though those objects were intended to be in separate databases.
For example:
- Sql1 contains a Table1
- Sql2 references Sql1 with DatabaseSqlCmdVariable="Sql1" and contains its own Table1
- Sql3 references Sql2 with DatabaseSqlCmdVariable="Sql2" and contains its own Table1
When building Sql3, the build would fail with collisions between Table1 objects, even though they should be considered as objects in separate databases.
Solution
The fix adds a target that runs after ResolveArtifactReferences to ensure that the DatabaseSqlCmdVariable metadata (and other database reference metadata) are preserved in transitive project references. This allows the build system to correctly identify that tables with the same name are actually in different databases when connected via the project reference chain.
Details of Changes
- Added a PreserveProjectReferenceDatabaseMetadata target in Sdk.targets that preserves DatabaseSqlCmdVariable, ServerSqlCmdVariable, and DatabaseVariableLiteralValue metadata from project references
- Created a test that reproduces the issue and verifies the fix works correctly
Testing
Added a test case that verifies build succeeds with transitive project references where all projects have objects with the same name but are marked as separate databases using DatabaseSqlCmdVariable.
Fixes #608.
[!WARNING]
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
crl3.digicert.com
- Triggering command:
dotnet build(dns block)crl4.digicert.com
- Triggering command:
dotnet build(dns block)ocsp.digicert.com
- Triggering command:
dotnet build(dns block)- Triggering command:
/home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js(dns block)s.symcb.com
- Triggering command:
dotnet build(dns block)s.symcd.com
- Triggering command:
dotnet build(dns block)ts-crl.ws.symantec.com
- Triggering command:
dotnet build(dns block)ts-ocsp.ws.symantec.com
- Triggering command:
dotnet build(dns block)If you need me to access, download, or install something from one of these locations, you can either:
- Configure Actions setup steps to set up my environment, which run before the firewall is enabled
- Add the appropriate URLs or hosts to my firewall allow list
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.
