CCF icon indicating copy to clipboard operation
CCF copied to clipboard

Stop keeping track of destroyed node-to-node channels

Open jumaffre opened this issue 4 years ago • 1 comments

We currently keep track of destroyed node-to-node channels (i.e. replace the std::shared_ptr<Channel> with nullptr in the channels map, instead of simply deleting the NodeId key).

We should try to fix, considering what may potentially break in some end-to-end tests (e.g. code update, reconfiguration).

jumaffre avatar Jun 15 '21 14:06 jumaffre

Link #2672

achamayou avatar Nov 08 '21 09:11 achamayou

This was done as part of #2801. In moving NodeToNodeChannelManager to its own file, we also removed the destroy_channel paths which filled the map with tombstone null pointers.

eddyashton avatar May 15 '23 15:05 eddyashton