BotFramework-WebChat icon indicating copy to clipboard operation
BotFramework-WebChat copied to clipboard

Missing dependency on p-defer-es5

Open nick-pape opened this issue 1 year ago • 0 comments

Is it an issue related to Adaptive Cards?

No

Is this an accessibility issue?

No

What version of Web Chat are you using?

Latest production

Which distribution are you using Web Chat from?

Bundle (webchat.js)

Which hosting environment does this issue primarily affect?

Web apps

Which browsers and platforms do the issue happened?

No response

Which area does this issue affect?

Development experience

Which theme pack does this issue affect?

I did not test it on other theme packs

What is the public URL for the website?

No response

Please describe the bug

Several pieces of code in this package import p-defer-es5 directly. However, this package is not listed in dependencies in package.json. This causes an issue with installers such as pnpm as they don't "flatten" the node_modules. Specifically, this is causing an issue in ODSP codebase. Please add p-defer-es5 as a dependency. Thanks!

Do you see any errors in console log?

No response

How to reproduce the issue?

  1. Use pnpm to install this package
  2. Try to run/webpack the code

What do you expect?

Webpack to succeed

What actually happened?

Webpack is unable to import p-defer-es5

Do you have any screenshots or recordings to repro the issue?

No response

Adaptive Card JSON

No response

Additional context

No response

nick-pape avatar May 03 '24 21:05 nick-pape