BotFramework-WebChat icon indicating copy to clipboard operation
BotFramework-WebChat copied to clipboard

Address XS code hygiene tasks

Open OEvgeny opened this issue 1 year ago • 1 comments

part of #4968

Changelog Entry

(No changelog entry for code hygiene tasks)

Description

Address the first 3 suggestions from #4968

Design

Specific Changes

List of changes:

  • [x] XS: Do not use React FC/VFC types, use Props instead
  • [x] XS: Mark all props as read-only, also any arrays and objects under it
  • [x] XS: Prefer import { type ABC } over import type { ABC }

-

  • [ ] I have added tests and executed them locally
  • [ ] I have updated CHANGELOG.md
  • [ ] I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • [ ] Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • [ ] Browser and platform compatibilities reviewed
  • [ ] CSS styles reviewed (minimal rules, no z-index)
  • [ ] Documents reviewed (docs, samples, live demo)
  • [ ] Internationalization reviewed (strings, unit formatting)
  • [ ] package.json and package-lock.json reviewed
  • [ ] Security reviewed (no data URIs, check for nonce leak)
  • [ ] Tests reviewed (coverage, legitimacy)

OEvgeny avatar Dec 21 '23 18:12 OEvgeny

@compulim if anything is missing, please let me know!

OEvgeny avatar Jan 02 '24 19:01 OEvgeny