BotFramework-Composer icon indicating copy to clipboard operation
BotFramework-Composer copied to clipboard

Number input, Expected responses editing is broken

Open JonathanFingold opened this issue 3 years ago • 6 comments

Describe the bug

The Expected responses field is now a single line property with no intuitive way [if any] to provide a multi-line .lu format value.

Version

Version: 2.0.0-nightly.244572.8406071 Electron: 8.2.4 Chrome: 80.0.3987.165 NodeJS: 12.13.0 V8: 8.0.426.27-electron.0

Browser

  • [x] Electron distribution
  • [ ] Chrome
  • [ ] Safari
  • [ ] Firefox
  • [ ] Edge

OS

  • [ ] macOS
  • [x] Windows
  • [ ] Ubuntu

To Reproduce

Steps to reproduce the behavior:

  1. Add a Prompt for a number action
  2. Go to the User input tab in the action's properties pane.
  3. See error: Expected responses is now a one-line input field, with the watermark mangled and no way to use the Enter key to create a multi-line value.

Expected behavior

This field should allow multi-line values (.lu format).

Screenshots

image

JonathanFingold avatar May 12 '21 23:05 JonathanFingold

I can't repro this when using defaultRecognizer, but i can see this in regex recognizer. @JonathanFingold are you using default recognizer or the regex recognizer?

boydc2014 avatar May 13 '21 04:05 boydc2014

If this is regex, then it is expected by current design, because regex recognizer doesn't depends on lu file, so we purposely make it a one line input for the pattern, and we will serialize the pattern into .dialog file directly (instead of .lu file). What we need to do is maybe update the placeholder to make it clear. The control itself looks right to me.

boydc2014 avatar May 13 '21 05:05 boydc2014

To shiproom: this is probably not a P0.

boydc2014 avatar May 13 '21 09:05 boydc2014

Shiproom - moving out of R13

sgellock avatar May 13 '21 15:05 sgellock

@boydc2014 , yes, I had set the dialog to use a RegEx recognizer.

  1. Some context sensitive help text associated with this field would be helpful.
  2. Replacing the placeholder/watermark text would also be helpful.

JonathanFingold avatar May 19 '21 17:05 JonathanFingold

We can take a placeholder/copy update. I'd like @garypretty to weigh in on what that copy should say.

cwhitten avatar Jun 07 '21 19:06 cwhitten

I wasn't able to reproduce the issue

OEvgeny avatar Feb 28 '24 20:02 OEvgeny