BotBuilder-Samples icon indicating copy to clipboard operation
BotBuilder-Samples copied to clipboard

processActivity returns a promise that must be handled

Open christopheranderson opened this issue 6 years ago • 0 comments

Describe the bug

Give a clear and concise description of what the bug is.

All process activity calls return a promise and, thus, need to be handled. Our current code patterns do not involve handling these promises leading to node.js WARNING messages. It will also cause restify to hang until socket timeout.

To Reproduce

Steps to reproduce the behavior:

  1. Take any JS sample (echo)
  2. Make the code inside process activity throw an error (manually inserting a throw into "processActivity" itself is the fastest)
  3. restify will hang and node.js will issue a warning for an unhandled promise rejection.

Expected behavior

Give a clear and concise description of what you expected to happen.

We should .catch(next) or .then(next, next) all process activity calls in our code.

Screenshots

If applicable, add screenshots to help explain your problem.

Additional context

Add any other context about the problem here.

[bug]

christopheranderson avatar Dec 03 '19 19:12 christopheranderson