Azure_Kinect_ROS_Driver icon indicating copy to clipboard operation
Azure_Kinect_ROS_Driver copied to clipboard

fix src/k4a_ros_device.cpp rclcpp::Duration(double)

Open soeroesg opened this issue 2 years ago • 1 comments

Fixes

Fixes #270

fix src/k4a_ros_device.cpp rclcpp::Duration(double)

Description of the changes:

  • rclcpp::Duration(double) does not exist in ROS humble, instead we can use rclcpp::Duration::from_seconds())

Required before submitting a Pull Request:

  • [x] I reviewed CONTRIBUTING.md
  • [x] I built my changes locally
  • [x] I tested my changes with a device
  • [x] I changed both the ROS1 and ROS2 branches (the change only applies to ROS2)

I tested changes on:

  • [x] Windows (I have no ROS on Windows but the change is minimal)
  • [x] Linux
  • [x] ROS1 (no change needed)
  • [x] ROS2

soeroesg avatar Sep 13 '23 12:09 soeroesg

Same here on kinect k4a sample for unity. Can it be used the same fix?

Thaina avatar Mar 29 '24 04:03 Thaina