AzureStorageExplorer icon indicating copy to clipboard operation
AzureStorageExplorer copied to clipboard

Color contrast of keyboard focus with background color is 1.119 : 1 on list item of download drop down button: A11y_Azure Tools Storage Explorer_Blob container_Download_Non text Contrast

Open kapilvaishna opened this issue 1 year ago • 24 comments

Preflight Checklist

Storage Explorer Version

1.36.2

Architecture

x64

Platform

Windows

OS Version

Windowns11

GitHub Tags

#A11yMAS; #A11yTCS; #Win32; #DesktopApp; #A11ySev2; #BM_AzureToolsStorageExplorer_Win32_Dec2024; #Azure Tools Storage Explorer; #WCAG1.4.11; #FTP; #A11yWCAG2.1; #External; #External:Chrome; #eDAD:3P:Bug239940; #Third part; #Regressed:04-03-25; #ResolvedByTT;

Environment Details:

Application: Microsoft azure storage explorer Version: 1.36.2 OS: Windows 11 Enterprise 24H2 Build: 26100.2605

Repro Steps

  1. Launch the Azure Tools Storage Explorer.
  2. TAB till "Blob container" in tree view and press ENTER key to expand it.
  3. TAB till any blob container and press ENTER key.
  4. TAB till "Download" button and press ENTER key.
  5. Press Down arrow key to list items
  6. Check the color contrast of keyboard focus
  7. Observe that Color contrast of keyboard focus with background color is 1.119 : 1 on list item of download dropdown button.

Actual Experience

Color contrast of keyboard focus with background color is 1.119 : 1 on list item of download drop down button.

Expected Experience

Color contrast of keyboard focus with background color should equal or greater than 3:1

User Impact:

Low visibility user will face difficulty to find the keyboard focus because color contrast of keyboard focus with background color is less than 3:1

Attachment

Image

kapilvaishna avatar Dec 06 '24 10:12 kapilvaishna

@kapilvaishna You mention a radio button, but we're not entirely sure what you are referring to. Can you provide a screenshot or GIF if the issue?

craxal avatar Dec 09 '24 18:12 craxal

@craxal sorry for inconvenience now corrected it and added screen shot in bug discerption.

kapilvaishna avatar Dec 10 '24 06:12 kapilvaishna

@kapilvaishna This list item in question is a context menu, and it is rendered by the system, not our application. We do not have any control over the colors of the menu.

craxal avatar Dec 10 '24 17:12 craxal

@craxal Could you please conform the external team service tree id/name and are path to rout this bug to them.

kapilvaishna avatar Dec 12 '24 10:12 kapilvaishna

@kapilvaishna I'm not sure. You'd have to redirect it to the Windows team.

Just to be clear, is the #F2F2F2 color in reference to the text or to the hover background? The #F2F2F2 color in Accessibility Insights doesn't seem to match the actual color of the text in the screenshot, and the text color seems to contrast enough to me. Please double-check.

If this is about the hover background color, then I don't think this is an actual violation of any standards. Some statements from WCAG 1.4.11:

Note that this requirement does not apply to inactive user interface components.

This Success Criterion does not require that changes in color that differentiate between states of an individual component meet the 3:1 contrast ratio when they do not appear next to each other. For example, there is not a new requirement that visited links contrast with the default color, or that mouse hover indicators contrast with the default state.

craxal avatar Dec 12 '24 20:12 craxal

@kapilvaishna Unless you have additional comments or can verify the details I mentioned above, I will be closing this as not a bug.

craxal avatar Dec 19 '24 23:12 craxal

@craxal i have verified, here color contrast is felling for keyboard focus indicator color with background color, and I am following on this to log external bug to window. As per external bug process once external bug will fix. I will verify and close this bug. Thanks!

kapilvaishna avatar Dec 20 '24 11:12 kapilvaishna

@kapilvaishna It looks like it's an issue with Electron, because other apps like Edge and File Explorer don't have this problem. I would still push the Windows end of things in case Electron pushes back saying they're just using Windows native menus.

Electron Other Apps
Image Image

I have created an issue against Electron: https://github.com/electron/electron/issues/45068. We update Electron regularly, so we'll keep an eye on this to see if an Electron update fixes this.

craxal avatar Dec 20 '24 17:12 craxal

Rev:inse

InduPriya1805 avatar Jan 06 '25 11:01 InduPriya1805

@kapilvaishna It appears that this is may be underlying issue with Chromium, which Electron depends on.

Since this an external issue, what's the process? Can we close or get an exception?

craxal avatar Jan 08 '25 00:01 craxal

@craxal I have dropped mail to chromium edge team to log external bug, as per the external bug process, Once the external bug is fixed and closed, we will verify and close this issue.

SL:External to chromium Edge:01-08-25

kapilvaishna avatar Jan 08 '25 10:01 kapilvaishna

There is an existing issue that appears to have been open for several years: https://issues.chromium.org/issues/40693702

craxal avatar Jan 08 '25 18:01 craxal

@craxal The external bug you mentioned is logged against Chrome. Could you please confirm whether the external team is Chrome or Chromium?

kapilvaishna avatar Jan 09 '25 10:01 kapilvaishna

There is effectively no difference. Chrome, Edge, Electron, and other projects are all based on Chromium. "Chrome" may be mentioned in the comments, but the bug itself is in Chromium, and fixes are committed to the Chromium code base, which will make their way to Electron.

craxal avatar Jan 09 '25 19:01 craxal

@craxal Please let us know once fixes are available.

kapilvaishna avatar Jan 27 '25 09:01 kapilvaishna

@kapilvaishna Again, the Chromium bug has been open for several years, so I doubt it will be fixed anytime soon. What is the policy on external issues?

craxal avatar Jan 27 '25 22:01 craxal

@craxal If any issue is external to first part (Internal to Microsoft) or third party. we follow different processes for each case.

If external team is first party than we will log the bug against them. Once the external bug is resolved and closed, proceed to verify and close the primary bug.

If external team is third party than We will share the sample application with the eDAD team, and they will file a bug against the third party.

I was checking with vendor team of chromium, but they informed me that they don't have that UI in Edge

kapilvaishna avatar Jan 28 '25 11:01 kapilvaishna

@kapilvaishna What do you mean by "they don't have that UI in Edge"? Do you mean to say that Edge uses different code for their menus? If that's true, that's fine, but that doesn't change the nature of the bug from our perspective. It's still an external bug that depends on changes in Chromium, which is a third party (linking to the issue again: https://issues.chromium.org/issues/40693702).

craxal avatar Jan 28 '25 17:01 craxal

@kapilvaishna Can you answer my above questions? External bugs are not something we can resolve within a well-defined timeline, so I don't see much reason for keeping this open.

craxal avatar Feb 12 '25 01:02 craxal

@craxal as per external but process I will log external bug for this issue and will share but here and till external bug is in active state we can't close this bug as per process.

kapilvaishna avatar Feb 12 '25 12:02 kapilvaishna

@kapilvaishna Do you have a link to the external bug that you can post here, please?

craxal avatar Apr 02 '25 21:04 craxal

GithubTags:#ResolvedByTT;

kupatkar99 avatar Apr 23 '25 12:04 kupatkar99

Followed up with testers. External bug has been acknowledged. Waiting for links to those external bugs.

craxal avatar Jun 13 '25 19:06 craxal

@kupatkar99 @kapilvaishna Any updates on the external bugs? I followed the link provided earlier, and I don't appear to have access to see what the current status is.

craxal avatar Sep 19 '25 00:09 craxal