AzureStorageExplorer icon indicating copy to clipboard operation
AzureStorageExplorer copied to clipboard
verified publisher icon microsoft

There is a failed activity log when clicking 'Play in Browse' in one file share which has the correct RBAC role

Open v-kellyluo opened this issue 1 year ago • 2 comments

Storage Explorer Version: 1.36.0 (101) Build Number: 20241009.1 Branch: rel/1.36.0 Platform/OS: Windows 10/Windows 11/Linux Ubuntu 22.04/MacOS Sequoia 15.0(Apple M1 Pro) Architecture: x64/arm64/x64/arm64 How Found: Exploratory testing Regression From: Not a regression

Steps to Reproduce

  1. Select one storage account.
  2. Assign RBAC roles 'Storage File Data Privileged Contributor' and 'Reader' to an azure account.
  3. Sign into storage explorer using the azure account.
  4. The storage account displays under the subscription.
  5. Expand the storage account -> File Shares.
  6. Open one file share -> Upload a .mp4 file -> Select the file -> Click 'Play in Browser'.
  7. Check whether succeeds to play the file in browser.

Expected Experience

Succeed to play the file in browser.

Actual Experience

There is a failed activity log. Image

Additional Context

  1. This issue also reproduces for other video files.
  2. This issue doesn't reproduce for blob containers.

v-kellyluo avatar Oct 10 '24 09:10 v-kellyluo

@v-kellyluo Can you share more information about the error? Is it an access error?

craxal avatar Oct 10 '24 22:10 craxal

@craxal , it isn't an access error, I can preview csv/parquet/avro files, only fails to open video files in browser.

  1. Here is the logs: 2024-10-11_022927.zip
  2. Here is the record: Image

v-kellyluo avatar Oct 11 '24 02:10 v-kellyluo

@richardMSFT First verify if this is really a regression or not with 1.35.0. Then see if you can get any more error information. From there, we can determine if this is worth fixing for 1.36.2.

craxal avatar Oct 28 '24 21:10 craxal

After investigating, seems like this is not a regression. In 1.35.0 file shares could not be accessed with those roles due to credentials not being suitable. In 1.36.0 when trying to play in browser a .mp4 file the error being thrown is that "File Share requires storage account key to generate SAS". So it looks like that File Shares don't support user delegated SAS.

The fix is that we can expose the error in the activity log and this would be a fix that falls under "better UX".

richardMSFT avatar Oct 28 '24 23:10 richardMSFT

I merged a change to disable this button when the file share explorer doesn't have key or SAS credentials.

JasonYeMSFT avatar Dec 07 '24 00:12 JasonYeMSFT

Verified this issue on the build 20241207.4. Fixed. Image

v-kellyluo avatar Dec 09 '24 02:12 v-kellyluo