AzureStorageExplorer icon indicating copy to clipboard operation
AzureStorageExplorer copied to clipboard
verified publisher icon microsoft

The string changes to blob container name if click the string 'Snapshot for XXX' in the snapshots/versions view

Open v-kellyluo opened this issue 1 year ago • 5 comments

Storage Explorer Version: 1.35.0-dev (100) Build Number: 20240810.1 Branch: rel/1.35.0 Platform/OS: Windows11/Windows 10/Linux Ubuntu 22.04/MacOS Sonoma 14.6(Apple M1 Pro) Architecture: arm64/x64/x64/arm64 How Found: Ad-hoc testing Regression From: Previous release (1.34.0)

Steps to Reproduce

  1. Expand one storage account -> Blob Containers.
  2. Create a blob container -> Upload a blob.
  3. Right click the blob -> Click 'Manage History -> Manage Snapshots'.
  4. Click the string 'Snapshot for XXX' in the address bar.
  5. Check whether the string in the address bar doesn't change.

Expected Experience

The string doesn't change.

Actual Experience

The string changes to blob container name. snap

Additional Context

  1. This issue also reproduces under versions view.
  2. This issue also reproduces for file share.

v-kellyluo avatar Aug 19 '24 07:08 v-kellyluo

@v-kellyluo , I'm confused. The "actual experience" gif shows:

  • Not what you described
  • What I would expect

That is: the address bar gets an additional path part of "Snapshots for '<BLOB NAME>'".

I also tested with 1.34 and 1.35 and the behavior is the same on both?

MRayermannMSFT avatar Aug 19 '24 14:08 MRayermannMSFT

Ah I see. I misread the issue. The "issue" is not about the content of the text. It is about what happens after clicking on the text. Gotcha.

MRayermannMSFT avatar Aug 19 '24 17:08 MRayermannMSFT

Update: This issue also reproduces when clicking the string in address bar if apply 'Filter by prefix/Tag Query'. 热

v-kellyluo avatar Aug 20 '24 07:08 v-kellyluo

It seems that the problem is due to the fact that we are generating a new location when the breadcrumb button is clicked. The history location is converted to a blank path which is then in turn converted to a list location at the root. What should be happening is essentially a no-op. This occurs in the onClick() button prop in AddressBar.tsx.

Fixing this involves updates to the UI components package, the blob extension, and the file extension. I don't think this is a breaking bug, considering that users can still click the back button to get back to viewing snapshots. So, I don't think this needs to be fixed for 1.36.0.

craxal avatar Sep 24 '24 18:09 craxal

Blocked till blob extension integrates the new explorer data grid hook from the updated v5 ui-components package. https://github.com/microsoft/AzureStorageExplorer/issues/7332

richardMSFT avatar Mar 07 '25 20:03 richardMSFT