AzureStorageExplorer icon indicating copy to clipboard operation
AzureStorageExplorer copied to clipboard

It would be better to use 'By' instead of 'by' in the setting 'Organize by Resource Group'

Open v-xianya opened this issue 1 year ago • 4 comments

Storage Explorer Version: 1.35.0-dev (98) Build Number: 20240607.1 Branch: main Platform/OS: Windows11/Windows 10/Linux Ubuntu 22.04/MacOS Sonoma 14.5(Apple M1 Pro) Architecture: arm64/x64/x64/arm64 How Found: Ad-hoc testing Regression From: Not a regression

Steps to Reproduce

  1. Open ‘Settings -> Services'.
  2. Observe the setting 'Organize by Resource Group'.
  3. Check whether it shows 'By' in the description.

Expected Experience

It would be better to update 'by' to 'By'.

Actual Experience

It shows 'by' in the description. image

v-xianya avatar Jun 07 '24 06:06 v-xianya

That is not correct usage. Unimportant words like prepositions are not typically capitalized unless they are at the beginning of a phrase.

craxal avatar Jun 07 '24 16:06 craxal

Hi @craxal In the settings, other prepositions are capitalized; should we maintain consistency? image

v-xianya avatar Jun 11 '24 06:06 v-xianya

Hi @craxal I think it would be better to maintain consistency for prepositions, so, we are going to re-open this issue.

v-xianya avatar Jun 12 '24 02:06 v-xianya

Agreed. We will fix these strings.

craxal avatar Jun 12 '24 16:06 craxal

Hi @craxal ,verified this issue on the build 20240716.5, the comments mentioned are fixed. But there are still some prepositions are capitalized, could you help to take a look? image

v-kellyluo avatar Jul 16 '24 02:07 v-kellyluo

@v-kellyluo I was not aware you were referring to all prepositions. The bug only mentioned the use of the word "by". I can fix these as well.

craxal avatar Jul 16 '24 16:07 craxal

Changes have been merged. Prepositions should have proper capitalization now. Please note, though that "Sign In With:" is now "Sign In with:". The word "in" is considered part of the "Sign In" feature and not quite a preposition, so it remains capitalized. However, "with" is a properly uncapitalized preopsition.

craxal avatar Jul 22 '24 21:07 craxal

Verified this issue on the main build 20240723.1. The current behaviors match the comments.

v-xianya avatar Jul 23 '24 01:07 v-xianya