AzureStorageExplorer icon indicating copy to clipboard operation
AzureStorageExplorer copied to clipboard

Update InnoSetup installer to be able to check for multiple other installs of Storage Explorer

Open MRayermannMSFT opened this issue 5 months ago • 0 comments

  1. Determine if there is a way to update the Storage Explorer InnoSetup installer to look for more than one "incompatible architecture" of Storage Explorer. Currently only a single "incompatible architecture" is specified (/dIncompatibleArchAppId).
  2. If the "way" is simple (like a day or so of work), just go ahead and do it.
  3. If the "way" is convoluted, check Storage Explorer telemetry to see what architectures of Storage Explorer that Windows ARM64 users are currently using. If the majority are on x64 Storage Explorer than just skip updating the isntaller to check for multiple architectures. If there is a mix/a majority are on x86, proceed with the enhancement.
  4. If the enhancement is done, then when ARM64 is the target arch, make sure to check both for x86 and x64 Storage Explorer.
  5. If the enhancement is not done, then when ARM64 is the target arch, make sure the installer at least looks for x64 Storage Explorer (I attempted to do this already, but there is currently a bug).

Helpful links:

  • InnoSetup nuget package: https://www.nuget.org/packages/Tools.InnoSetup . Needed to locally build installer (can also just use CI builds to build installer).
  • InnoSetup docs: https://jrsoftware.org/ishelp/ .
  • VS Code .iss file: https://github.com/microsoft/vscode/blob/main/build/win32/code.iss . Last I looked they did multiple "incompatible architecture" checking.
  • How to create Windows ARM64 VM on Azure: https://learn.microsoft.com/en-us/windows/arm/create-arm-vm .

Related to: https://github.com/microsoft/AzureStorageExplorer/issues/6072

MRayermannMSFT avatar Mar 12 '24 22:03 MRayermannMSFT