AzureStorageExplorer icon indicating copy to clipboard operation
AzureStorageExplorer copied to clipboard

"Clone" should allow a destination outside the source's directory

Open fgaonet opened this issue 3 years ago • 3 comments

Preflight Checklist

Storage Explorer Version

1.23.0

Regression From

No response

Architecture

i86

Storage Explorer Build Number

20220223.14

Platform

Windows

OS Version

Windows 10

Bug Description

I realized the "Copy" replaced by "Clone". As the description on popups, "Cloning works by copying to a new location." However, the "New name" box said "Name must not be empty or containing slashes". I wonder how to enter a folder name or container name to a new location?

I have tried to use ">" instead of "/", but it only changes the blob name and still in the same location.

Is it a bug??

Steps to Reproduce

  1. create a container with name of "container1".
  2. upload a file "blob1" into "container1".
  3. Try to clone "blob1" to a folder "folder1".
  4. What name should be entered into the "New name" box?

Actual Experience

Whatever you entered, the new "cloned" blob is still in the original location.

Expected Experience

I expect "blob1" in "folder1", i.e. folder1/blob1, if show blobs in container with Flat mode.

Additional Context

No response

fgaonet avatar Mar 09 '22 03:03 fgaonet

"Clone" replaces "rename", not "copy". Are you saying that you want to move "blob1" to be in a sibling folder "folder1" so that it ends up being "folder1/blob1"? If that's the case, you can right click "blob1", choose "copy", open "folder1" and "paste" there. This should be very similar to how to copy paste files in the file explorer.

JasonYeMSFT avatar Mar 09 '22 19:03 JasonYeMSFT

Thank you for the explanation! You are right on remote Azure storage. I just realized the “copy”, “paste” functions still there.

However, there are no such buttons on my local emulator blob containers. I tried right-clicking the “blob1” which is in my local emulator blob container, but cannot find “copy” “paste” options on the popup menu. How do I move a blob in a folder in local emulator?

By the way, I am still confused with the description on the Clone popup, “Cloning works by copying to a new location”. What does “new location” mean?

Frank

From: @.> Sent: Wednesday, March 9, 2022 2:53 PM To: @.> Cc: @.>; @.> Subject: Re: [microsoft/AzureStorageExplorer] "Clone" does not work (Issue #5509)

"Clone" replaces "rename", not "copy". Are you saying that you want to move "blob1" to be in a sibling folder "folder1" so that it ends up being "folder1/blob1"? If that's the case, you can right click "blob1", choose "copy", open "folder1" and "paste" there. This should be very similar to how to copy paste files in the file explorer.

— Reply to this email directly, view it on GitHubhttps://github.com/microsoft/AzureStorageExplorer/issues/5509#issuecomment-1063305541, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACPBDDVKWME3UQ6U4SJ5XKTU7D6VDANCNFSM5QIKWT2A. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you authored the thread.Message ID: @.***>

fgaonet avatar Mar 10 '22 01:03 fgaonet

Copy and Paste aren't supported by our emulator related code because we don't have the implementation to tell if the copied blobs can be visible from the destination. As of today, clone's destination is limited to the same directory the source blob is in. I can update the title to turn this issue into a feature request.

JasonYeMSFT avatar Mar 10 '22 18:03 JasonYeMSFT

This is totally doable except that it will significantly complicate validation on the new blob name.

JasonYeMSFT avatar Jan 12 '23 00:01 JasonYeMSFT

This feature will be shipping with 1.29.0.

richardMSFT avatar Mar 14 '23 22:03 richardMSFT