AzureStorageExplorer icon indicating copy to clipboard operation
AzureStorageExplorer copied to clipboard

Keep consistent behaviors between pasting one empty folder and more than one empty folder against file shares

Open v-xianya opened this issue 2 years ago • 3 comments

Storage Explorer Version: 1.22.0-dev Build Number: 20210924.14 Branch: hotfix/1.21.2 Platform/OS: Windows 10/Linux Ubuntu 20.04/MacOS Big Sur 11.4 Architecture: ia32\x64 How Found: Ad-hoc testing Regression From: Not a regression

Steps to Reproduce

  1. Expand one storage account -> File Shares.
  2. Create a file share-> Create three new empty folders (f1, test1, test2).
  3. Copy the folder test1 then paste it into the folder f1.
  4. Observer the activity log.
  5. Back to the root -> Select the two folders test1 and test2.
  6. Copy the two folders then paste them into the folder f1.
  7. Observe the activity log.
  8. Check whether the behaviors are consistent.

Expected Experience

The behaviors are consistent.

Actual Experience

The behaviors are inconsistent. image

Additional Context

  1. For ADLS Gen2 blob containers, always display '0 items transferred' regardless of how many empty folders are pasted.
  2. Related issue 3193.

v-xianya avatar Sep 26 '21 09:09 v-xianya

Let's understand why the numbers are different and open a bug against AzCopy if needed.

MRayermannMSFT avatar Sep 27 '21 17:09 MRayermannMSFT

For single folder copy, the AzCopy command looks like cp root/src/* somewhere/src/

And since root/src/ is empty, AzCopy thinks there is nothing to copy and exits.

For multiple folder copy, the AzCopy command looks like cp root/* somwhere/

with list of files as: src1/ src2/

AzCopy lists under root and finds the two folders and thus creates the two folders.

I think for us, this is a low priority bug. If the folder to copy is empty, the user can always create the folder at the destination instead.

Potential fix can be:

  • AzCopy always create the folder at the destination
  • We always use the list of files to specify folders to copy

Let's discuss with AzCopy team on their expectation and decide which one to take.

JasonYeMSFT avatar Dec 03 '21 23:12 JasonYeMSFT

This work needs a new AzCopy flag planned for their next release.

JasonYeMSFT avatar Mar 09 '22 18:03 JasonYeMSFT

For file share, the activity now includes the directory in the job summary (e.g. 1 item if copying an empty directory, etc.). For blob/gen2 the behavior will remain the same (e.g. 0 item if copying an empty directory, 0 items if copying 2 empty directories) because the AzCopy flag doesn't work for blob.

JasonYeMSFT avatar Sep 23 '22 21:09 JasonYeMSFT

@JasonYeMSFT Verified this issue on the build main 20220926.1. The current behavior as below

  1. For file share, display the correct number when copying empty folders for file share. (1 item if copying an empty directory, 2 items if copying 2 empty directories)
  2. For ADLS Gen2 blob container. (0 item if copying an empty directory, 0 items if copying 2 empty directories)

BTW, Is there a typo in (e.g. 0 item if copying an empty directory, 2 items if copying 2 empty directories)

For file share, the activity now includes the directory in the job summary (e.g. 1 item if copying an empty directory, etc.). For blob/gen2 the behavior will remain the same (e.g. 0 item if copying an empty directory, 2 items if copying 2 empty directories) because the AzCopy flag doesn't work for blob.

v-xianya avatar Sep 26 '22 02:09 v-xianya

Oh, sorry there is a typo. For gen2 and blob, empty directories will be ignored.

JasonYeMSFT avatar Sep 26 '22 16:09 JasonYeMSFT

@JasonYeMSFT Thank you for the response, The behaviors are the same as the comments. Will close this issue.

v-xianya avatar Sep 27 '22 02:09 v-xianya