AzureStorageExplorer icon indicating copy to clipboard operation
AzureStorageExplorer copied to clipboard

Adding a SAS URL with api-version

Open dgkanatsios opened this issue 6 years ago • 4 comments

Storage Explorer Version: 1.10.1 Build Number: 20190919.2 Platform/OS: Windows Architecture: ia32 Regression From: Not sure

Bug Description

Infinite loading icon on Blob Containers treeview item if you add an account with an SAS Url that contains api-version.

Steps to Reproduce

Add an account with an SAS Url that contains api-version. Account gets added successfully, but when you try to browse Blob Containers you get an infinite loading icon. The only way to find out what's going on is to F12 and see in the console the "Uncaught SyntaxError: the SAS token should not contain api-version".

Expected Experience

Either it should just work or Storage Explorer should display an error

Actual Experience

1

Thank you!

dgkanatsios avatar Oct 16 '19 17:10 dgkanatsios

also forgot to write the SAS URL I'm using

https://wuslogdz24fwxy3kb6g.blob.core.windows.net/vmmetrics?sv=2015-04-05&ss=b&srt=sco&sp=racwdl&st=2019-10-16T17%3A08%3A17.5341813Z&se=2019-11-15T19%3A08%3A17.5341813Z&spr=https&sig=REDACTED&api-version=2018-03-28

dgkanatsios avatar Oct 16 '19 20:10 dgkanatsios

I have gone through the documentation and did some experiments. The service does support SAS parameter api-version and this error seems to be an issue of the V2 SDK we were using. For blobs and queues, which we already migrated to v12 SDK, the SAS url works just fine.

JasonYeMSFT avatar Sep 03 '20 19:09 JasonYeMSFT

We are moving our features depending on V2 to V12 SDK. When all are moved, this will be supported.

JasonYeMSFT avatar Oct 16 '20 00:10 JasonYeMSFT

We have moved all four services to V12 SDK so we just need to verify this scenario now.

JasonYeMSFT avatar Oct 06 '22 17:10 JasonYeMSFT

By allow people to specify SAS version in the SAS tokens we generate, it would help mitigate this issue https://github.com/microsoft/AzureStorageExplorer/issues/6314.

JasonYeMSFT avatar Dec 06 '22 23:12 JasonYeMSFT

Confirmed support of api-version in SAS url when attaching accounts. Shipping with 1.29.0 is also the ability to configure api-version as an optional parameter in the SAS generator dialog for accounts and services.

richardMSFT avatar Apr 17 '23 23:04 richardMSFT