ApplicationInsights-dotnet icon indicating copy to clipboard operation
ApplicationInsights-dotnet copied to clipboard

Simplify Configuration of Advanced Options for Adaptive Sampling

Open bdschaap opened this issue 4 years ago • 6 comments

I would like to request that configuration of advanced options for Adaptive Sampling be simplified.

The current approach described here is different than configuration of other options which is described here. I would like to be able to configure the advanced options in a similar manner to the basic options.

bdschaap avatar Oct 01 '20 11:10 bdschaap

ApplicationInsightsServiceOptions is intended to provide an ability to turn on/off some common feature. Its currently not intended to have all the settings for each feature. No investments are planned in this area in current year.

cijothomas avatar Oct 01 '20 14:10 cijothomas

I want to second this request by @bdschaap . It would be very useful to be able to configure these kinds of things via the configuration API - i.e., in the appsettings file or via environment variables. It's currently really easy to shoot yourself in the foot by reconfiguring adaptive sampling while forgetting to set EnableAdaptiveSampling to false, so that alone should justify adding these options to ApplicationInsightsServiceOptions. From the docs:

image

Also, these settings used to be configurable in ApplicationInsights.config, so it seems straight-forward that they should also be configurable via appsettings, doesn't it?

fschmied avatar Aug 27 '21 17:08 fschmied

This issue is stale because it has been open 300 days with no activity. Remove stale label or this will be closed in 7 days. Commenting will instruct the bot to automatically remove the label.

github-actions[bot] avatar Jun 24 '22 00:06 github-actions[bot]

This is still an issue.

fschmied avatar Jun 24 '22 04:06 fschmied

This issue is stale because it has been open 300 days with no activity. Remove stale label or this will be closed in 7 days. Commenting will instruct the bot to automatically remove the label.

github-actions[bot] avatar Apr 22 '23 00:04 github-actions[bot]

It is still an issue.

fschmied avatar Apr 24 '23 06:04 fschmied