ApplicationInsights-Java icon indicating copy to clipboard operation
ApplicationInsights-Java copied to clipboard

Use upstream micrometer instrumentation

Open trask opened this issue 1 year ago • 3 comments

TODO need to manually test old actuator instrumentation, because I haven't been able to get old spring boot versions to work since upgrading to Gradle 8.1.1.

Resolves #2806 and https://portal.microsofticm.com/imp/v3/incidents/incident/409304026

The 63 character limit for OTel metric names which could introduce regressions for existing users by moving to the upstream instrumentation is resolved now in OTel Java v1.30.0.

trask avatar Aug 08 '23 23:08 trask

@trask is this ready for review?

heyams avatar Sep 07 '23 15:09 heyams

This comment is only for Micrometer < 1.5?

jeanbisutti avatar Sep 20 '23 12:09 jeanbisutti

This comment is only for Micrometer < 1.5?

I reworded it a bit, also check out https://github.com/microsoft/ApplicationInsights-Java/pull/3245/files#diff-1b736bfc6f05aef23179b4913d150fb5dad450dbf3297fe3a875dccfed3736b4R191-R199

trask avatar Sep 20 '23 17:09 trask