ApplicationInsights-Java icon indicating copy to clipboard operation
ApplicationInsights-Java copied to clipboard

Configure the JMX metrics to include multiple attributes per objectName

Open MS-jgol opened this issue 3 years ago • 6 comments

@trask Please review

MS-jgol avatar Apr 01 '21 06:04 MS-jgol

@trask I added some comments within the code that I will need to remove - there are a few questions/assumptions for an easier review

MS-jgol avatar Apr 01 '21 06:04 MS-jgol

/azp list

VenumadhavDuriseti avatar Apr 06 '21 20:04 VenumadhavDuriseti

Same here - not very familiar with the required test structure. Do we need a way to handle the exception here? What is the proper way for the test purposes - remove? change to finally?

I pushed an update to your branch to remove those two catch blocks

trask avatar Apr 07 '21 17:04 trask

@heyams can you look at the pipeline failure?

trask avatar Apr 29 '21 19:04 trask

@heyams can you look at the pipeline failure?

onebranch experienced an outage with their service account.. System.InvalidOperationException: Task Get Service Tree Data failed to exit with a success (0) exit code will go away automatically. I triggered a new build.

heyams avatar Apr 30 '21 18:04 heyams

closing, we are going to align with OpenTelemetry custom JMX metrics configuration options once that is implemented

trask avatar Aug 15 '22 21:08 trask