ApplicationInsights-JS icon indicating copy to clipboard operation
ApplicationInsights-JS copied to clipboard

[BUG]urlCollectQuery not work for applicationinsights-clickanalytics-js

Open lingfeidiewu opened this issue 3 years ago • 3 comments

Description/Screenshot In the ReadMe of applicationinsights-clickanalytics-js, there are two configuration urlCollectQuery and urlCollectHash. But after I set these two configuration as true, the uri in the event data still doesn't include the query string in url. I also cannot find any code related to urlCollectQuery in the repository. Are these two configurations useful to collect query string in url for auto captured click events?

lingfeidiewu avatar Jul 25 '22 09:07 lingfeidiewu

Looking at the code, I'm not finding any references to these properties -- looks like they got removed before the project was released. I don't have the details on why, will need to assign someone to investigate further...

@lingfeidiewu Right now, No these two configurations are not useful, at the very minimum this is a documentation bug. But we may be able to do something.

@Karlie-777, I'll raise a task and assign for August review.

MSNev avatar Jul 25 '22 20:07 MSNev

Thanks. I think these two configurations are needed, now the query string are discarded in the click events data.

lingfeidiewu avatar Jul 26 '22 02:07 lingfeidiewu

The configs are removed in this PR: https://github.com/microsoft/ApplicationInsights-JS/pull/1444 And the changes on Readme are back in PR: https://github.com/microsoft/ApplicationInsights-JS/pull/1455 due to auto merge

Karlie-777 avatar Aug 03 '22 16:08 Karlie-777

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

github-actions[bot] avatar Sep 15 '23 00:09 github-actions[bot]