ApplicationInsights-JS icon indicating copy to clipboard operation
ApplicationInsights-JS copied to clipboard

[BUG] Unmet peer dependency of tslib warning from yarn

Open chadsowald opened this issue 3 years ago • 4 comments

Description/Screenshot image

Similar to #1114 which although is marked as fixed, I still see tslib in peer deps in the package.json here: https://github.com/microsoft/ApplicationInsights-JS/blob/master/shared/AppInsightsCore/package.json#L61

Shouldn't that be moved to devDependencies or just removed all together?

Repro steps:

  • Create a new folder
  • Run yarn init and accept defaults
  • Run yarn add @microsoft/applicationinsights-web
  • Notice warnings!

Expected behavior No warnings

chadsowald avatar Apr 08 '22 00:04 chadsowald

I believe this is an issue with your project in that you will need to include tslib into your package.json.

Internally, we dynamically replace all internal tslib references so we are not dependent or tied to specific versions, which is also why we have it listed as a generic "*" (all version) peerDependency.

We could try removing all peerDependency references, but I believe last time we did this some version (don't remember which) used by some customers complained that we didn't include it and rather than a warning it was an error.

MSNev avatar Apr 08 '22 15:04 MSNev

This Issue will be closed in 30 days. Please remove the "Stale" label or comment to avoid closure with no action.

github-actions[bot] avatar Feb 13 '23 07:02 github-actions[bot]

This is still a schedule task, it's just lower priority to try and remove it as a peer dependency so it's kept getting moved.

MSNev avatar Mar 16 '23 16:03 MSNev

This Issue will be closed in 30 days. Please remove the "Stale" label or comment to avoid closure with no action.

github-actions[bot] avatar Jan 12 '24 07:01 github-actions[bot]