microsoft
[Designer] Update container styling to fix overflow and sizing
Related Issue
Fixes #7883
Description
Updated the berlin styling to use margins instead of padding because overflow was not working properly.
Also adjusted the height and width because the border is not included in the given sizes.
How Verified
Verified manually on the Adaptive Cards site.
Microsoft Reviewers: Open in CodeFlow
Hi @anna-dingler. Thanks for helping make the AdaptiveCards JS renderer + tooling better. As additional verification, once the JS build succeeds, please go to the test site to test out your website/designer changes.
Hi @anna-dingler. This pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along.
Hi @anna-dingler. This pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along.
@JeanRoca When is a good time to make this update?
I spoke with Amanda and she suggested we can take the change as long as it does not impact our partners. I was doing some testing and noticed a couple of things with the new margin.
- Background images are not bleeding outside the margins.
PR
Current designer
- Carousel controls should also bleed into the margins so they don't disappear.
The only 3 things that should be allowed to extend past the margin are carousel pagination dots, carousel next/prev arrows, and background images (either set at the AC level or set in something like the carousel which supports bleed for background images). Let me know if you think of any others that should be able to extend past the margins.
Once these changes are made we can test to make sure it does not impact partners and go from there. Thanks Anna :)
Hi @anna-dingler. This pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along.