AdaptiveCards icon indicating copy to clipboard operation
AdaptiveCards copied to clipboard

Revisit accessibility solution in https://github.com/microsoft/AdaptiveCards/pull/6763#issuecomment-1171999511

Open licanhua opened this issue 3 years ago • 1 comments

Revisit https://github.com/microsoft/AdaptiveCards/pull/6763#issuecomment-1171999511 @compulim

(I know not many people will read comments in merged/closed PRs. But I will just keep it here.)

IMO, role="toolbar" is a better role for grouping buttons. Some screen readers read "1 of 6" even without aria-posinset for things inside role="toolbar".

Turning a button into menu item hurts accessibility as shortcut keys that normally applies to buttons (and form fields) will no longer apply to menu item. Say, pressing B or F in Narrator will jump to the next closest button. However, it won't jump to button[role="menuitem"].

Buttons in toolbar are still buttons. Buttons in menu bar are no longer buttons. Better to stay as close to its original form as possible.

licanhua avatar Jul 01 '22 18:07 licanhua

@paulcam206 FYI

beervoley avatar Jul 11 '22 20:07 beervoley