AL icon indicating copy to clipboard operation
AL copied to clipboard

BlankZero and Editable modification are not detected as "not supported"

Open dannoe opened this issue 4 years ago • 3 comments

Please include the following with each issue:

1. Describe the bug I was transforming code from C/AL to AL and neither the txt2al (it's okay) or the AL vsx did error (or at least warn) me about the following:

  • BlankZero modifications on a existing field inside a TableExtensions are not supported
  • Editable modifications on a existing part inside a PageExtensions are not supported

Only the publishing of the app has told me:

Reason: An error occurred while applying changes from the object of type 'PageExtension' with ID '50000' 
in the 'xyz by xyz 1.0.0.0' app to the application object of type 'Page' with the ID '5725'. Failing delta: 
Type: ContentChangeDelta; TargetKind: FactBoxes; TargetId: Control1905767507; TargetType: ControlBaseDefinition
The error was: InvalidOperationException - Metadata delta application failed due to the following error(s): 
Modifications to property Editable are not supported.

2. To Reproduce Steps to reproduce the behavior:

  • Create TableExtensions and modify BlankZero of a base field.
  • Create PageExtension and modify Editable of a base part.

3. Expected behavior VS Code should warn/error/tell me.

4. Actual behavior Nothing.

5. Versions:

  • AL Language: v6.6.434101
  • Visual Studio Code: Version: 1.54.3
  • Business Central: 17

dannoe avatar Mar 29 '21 21:03 dannoe

Maybe those changes should be OK, though? They can't affect the schema and are really just cosmetic (in fact I wonder if BlankZero even belongs on a table, other than for convenience!)

dzzzb avatar Mar 30 '21 08:03 dzzzb

Is there any Progress on this feature? I had the same problem with the Modifaction of the Editable Property. Thankfully this error is recognized on publishing the extension in our buildpipeline resulting in the following error.

##[error]An error occurred while applying changes from the object of type 'PageExtension' with ID 'XXX' in the 'AppName publisher 0.1.0.9860' app to the application object of type 'Page' with the ID '7374'. Failing delta: Type: 'ContentChangeDelta'; TargetKind: 'FactBoxes'; TargetId: 'Control2'; TargetType: 'ControlBaseDefinition'; PropertyNames: 'Editable'; The error was: InvalidOperationException - Metadata delta application failed due to the following error(s): Modifications to property Editable are not supported.

pri-kise avatar Dec 06 '21 06:12 pri-kise

Same issue here with v20.1.ES SaaS.

CodeCops don't rise any error or warning...

I can build the .APP but surprisingly I can't deploy it.

Please, allow this type of changes or at least add it to CodeCops.

JavierFuentes avatar May 26 '22 18:05 JavierFuentes

Closing as duplicate of #7670 which is considered for triage.

qutreson avatar Feb 21 '24 12:02 qutreson

@qutreson is the "Editable" property for PageExtension parts also covered by the other issue? Or should I create a new issue for that?

dannoe avatar Feb 21 '24 14:02 dannoe

@dannoe - We will cover both

qutreson avatar Feb 21 '24 16:02 qutreson

@dannoe - Looking further into this, it seems that support for Editable on factboxes was removed with runtime version 10.1 (current one is 12 and soon 13) as part of #7133

image

If you need this capability, you should rather suggest this on aka.ms/BCIdeas as it appears then as a new feature rather than a bug.

qutreson avatar Mar 05 '24 14:03 qutreson