AL-Go icon indicating copy to clipboard operation
AL-Go copied to clipboard

Add .pre-commit-config.yml file with pre-commit hooks

Open cegekaJG opened this issue 1 year ago • 2 comments

This pull request adds a .pre-commit-config.yaml file to the repository, which includes pre-commit hooks for code formatting and quality checks.

The hooks can be installed locally using this guide to check for and rectify any violations before committing files, but using pre-commit.ci, it's also possible to register this repository to be automatically corrected and updated by a bot. This way, any pull requests for this project will either always adhere to guidelines defined by the hooks, or fail a status check if they require manual adjustments.

To enable pre-commit.ci, it's important to log into the service and authorize access to this repository. Beyond that, no further action is required.

Here's a list of all the hooks added with the .pre-commit-config.yml file. All of them pass after a single autofix commit.

  • executablebooks/mdformat/mdformat
  • pre-commit/pre-commit-hooks/check-added-large-files
  • pre-commit/pre-commit-hooks/check-case-conflict
  • pre-commit/pre-commit-hooks/check-json
  • pre-commit/pre-commit-hooks/check-xml
  • pre-commit/pre-commit-hooks/check-yaml
  • pre-commit/pre-commit-hooks/check-merge-conflict
  • pre-commit/pre-commit-hooks/detect-private-key
  • pre-commit/pre-commit-hooks/end-of-file-fixer
  • pre-commit/pre-commit-hooks/trailing-whitespace
  • pre-commit/pre-commit-hooks/mixed-line-ending
  • pre-commit/pre-commit-hooks/sort-simple-yaml

cegekaJG avatar Feb 27 '24 09:02 cegekaJG

This has been requested for review for almost 2 months now - can someone look at this already? If there's something missing or you need more information, please let me know.

cegekaJG avatar Apr 17 '24 06:04 cegekaJG

Hey @cegekaJG

First of all, thank you for taking the time to contribute to the AL-Go repository.

The PR looks okay. However, there's a certain process when using 3rd party frameworks for Microsoft projects, so the ball is on us to figure it out.

We'll keep you posted.

mazhelez avatar Apr 17 '24 07:04 mazhelez