AL-Go icon indicating copy to clipboard operation
AL-Go copied to clipboard

Enable blocking pull requests that add new warnings

Open jonasblunck opened this issue 8 months ago • 0 comments

Things to consider for feedback:

  1. Invoking the check for warnings as the last thing in RunPipeline.ps1. Could move to a step in _BuildALGoProject.yaml, but not sure how value it adds?
  2. Should the setting be named 'checkForNewWarnings', or 'blockNewWarnings', etc?
  3. We could optimize runtime by only comparing warnings when the number of warnings from baseline has changed, with the risk of ignoring new warnings if introduced at the same time as other warnings are removed.
  4. Warnings are only stored in the log if the setting 'enableCodeCop' is set to true. Should we throw an error if checkForNewWarnings is $true but enableCodeCop is $false?
  5. A new compiler version could add new warnings. In this case, a new 'official' build has to run before a PR can be completed.

jonasblunck avatar Apr 28 '25 09:04 jonasblunck