ADBench icon indicating copy to clipboard operation
ADBench copied to clipboard

Published 20 hours ago • verified publisher icon microsoft

Module directories lower case

Open tomjaguarpaw opened this issue 5 years ago • 5 comments

In the following documentation we see that module directory names must be lower case but the module binary name can be upper case. Is there a particular reason for changing the case? Does something go wrong if we choose it to be exactly the same as the module binary name?

https://github.com/awf/ADBench/blob/18dcb403aa50895a8700d69ea83253eab9079a39/docs/cpp/Modules.md#adding-new-modules

tomjaguarpaw avatar Sep 11 '19 12:09 tomjaguarpaw

run-all script uses this convention to run modules in the current implementation. But I don't see any obstacles to rename existing folders and change run-all script to meet your convention.

novikov-alexander-zz avatar Sep 11 '19 12:09 novikov-alexander-zz

I think it would make life a simpler if there is no difference between the two. Let's leave this issue open for a bit in case anyone else knows a reason why we shouldn't change it.

tomjaguarpaw avatar Sep 11 '19 13:09 tomjaguarpaw

I've discussed it with @msdmkats and we concluded that there are no any other special reasons. So, I will close this issue after I fix it.

novikov-alexander-zz avatar Sep 11 '19 13:09 novikov-alexander-zz

OK, that will be great.

tomjaguarpaw avatar Sep 11 '19 16:09 tomjaguarpaw

Sorry, I don't have time to finish it. So, it will be closed when someone else fix it.

novikov-alexander-zz avatar Oct 02 '19 10:10 novikov-alexander-zz