cli icon indicating copy to clipboard operation
cli copied to clipboard

CLI v1.0.0-alpha 6 Bug Hunt

Open ghost opened this issue 5 years ago • 17 comments

Known issues:

  • The dropdown button's svg doesn't work in production builds
  • Nicer CLI logging when yaml has syntax errors

ghost avatar Oct 18 '19 13:10 ghost

Look into design of setup.py page vs edit the yaml page.

Setup page: Screenshot from 2019-10-18 19-03-14

Edit YAML page (Looks much more clean and aligned): image

Also maybe we can make going back consistent. Setup page uses a X icon and Edit Yaml page used a Back icon.

adnrs96 avatar Oct 18 '19 13:10 adnrs96

When I click on edit the yaml, with a microservice that does not have environment variables and I try to add environment: at the end, it fails the container building (which is OK) But, going back to the main view and going on setup breaks the UI on that view, when the yaml is wrongly defined, see:

image

How to reproduce:

image

image

JeanBarriere avatar Oct 18 '19 13:10 JeanBarriere

re @adnrs96

Alignment has been fixed in https://github.com/microservices/oms/pull/270/commits/bade253f1542f094a058326c8bf4be0db61c75ae

Post alignment fix:

ghost avatar Oct 18 '19 13:10 ghost

Screen Shot 2019-10-18 at 15 36 02

Should be more informative to help the user. Guide them to the docs or some quick-start step that concerns this exact step.

stevepeak avatar Oct 18 '19 13:10 stevepeak

Better intro warnings for Docker daemon must be running before build images. Maybe a popup or something (again more help for devex) Screen Shot 2019-10-18 at 15 38 53

stevepeak avatar Oct 18 '19 13:10 stevepeak

Previous log not removed after docker daemon turned on https://cl.ly/1f94f17cecdb

stevepeak avatar Oct 18 '19 13:10 stevepeak

Untitled IS there a purpose for these. I can't seem to drag and resize windows using this.

adnrs96 avatar Oct 18 '19 13:10 adnrs96

dash Shouldn't the cursor not change because nothing seems to be clickable

adnrs96 avatar Oct 18 '19 13:10 adnrs96

image

This image was captured with 1440x900 res

adnrs96 avatar Oct 18 '19 13:10 adnrs96

  1. Log scroll padding issue https://cl.ly/d8a362995732
  2. feature Keyboard shortcuts (eg. h for show history)
  3. feature can we use placeholders too? https://cl.ly/107f7a521d7b I've seen this in other idea, sometimes like purple blocks with a cursor icon in them.
  4. No X on first tab (when only tab) which maybe should delete and start fresh https://cl.ly/75f631ba5d18
  5. Says started, no errors, but wont work https://cl.ly/e9b477c25ba9
  6. Need tooltip of what this is https://cl.ly/c6e9b79d2f11
  7. Click X on action dropdown should clear out the request data automatically, see here
  8. to pick a history, i must click the text not the li item, https://cl.ly/2e191293ae15
  9. edit yaml, logs UI issue: https://cl.ly/e1f3201f48c2
  10. need to link to docs: https://cl.ly/7f6e7138dd13 and it was not clear that that X meant "I should do it" vs it's broken
  11. docker inspect does nothing

stevepeak avatar Oct 18 '19 14:10 stevepeak

While editing the microservice.yml, can we ensure the microservice yml is valid (yaml syntax is OK and validation pass) before trying to rebuild the container ?

JeanBarriere avatar Oct 18 '19 14:10 JeanBarriere

dash

adnrs96 avatar Oct 18 '19 14:10 adnrs96

Should the arguments change when we try to change action ? https://www.loom.com/share/8bd11e31a7cd498d8cda0f521edc9b9f?focus_title=1&muted=1

JeanBarriere avatar Oct 18 '19 14:10 JeanBarriere

Also, can we add a shortcut like "ctrl+enter" to automatically submit the request

JeanBarriere avatar Oct 18 '19 14:10 JeanBarriere

image

small detail but -v / --verbose sounds more appropriate than --raw

JeanBarriere avatar Oct 18 '19 14:10 JeanBarriere

Please, show me the usage: image

JeanBarriere avatar Oct 18 '19 14:10 JeanBarriere

Re setup screen padding and scrolling issue, It's been fixed in https://github.com/microservices/oms/commit/184e9b8d840eff212e58e0ac68cecbe13293bcd1

ghost avatar Oct 18 '19 14:10 ghost