/micropython/bluetooth/aioble/examples/temp_client.py: Fix units in ADV_INTERVAL constant.

Open DavesCodeMusings opened this issue 1 year ago • 3 comments

The aioble README already has this fix: https://github.com/micropython/micropython-lib/commit/57ce3ba95c65d9823e8cc5284003967ff621bd46

This makes a similar correction to the temp_sensor.py example.

Oct 04 '24 16:10 DavesCodeMusings

Thanks for the contribution. Line 53 will also need fixing, as per the CI error.

Also, probably worth fixing the examples/l2cap_file_server.py example as well?

Oct 18 '24 00:10 dpgeorge

@dpgeorge Unfortunately, I found out about the guidelines for commits after I submitted a pull request. So yeah, there are some things I need to straighten out. Getting there... slowly. Still trying to figure out how I can do all this from the github.com web interface. Not so sure about the git -s signing bit. Can that be done in a browser or command-line only?

Oct 18 '24 22:10 DavesCodeMusings

Not so sure about the git -s signing bit. Can that be done in a browser or command-line only?

It should work through the browser now, I just enabled the relevant setting. If you add a new commit it should be signed.

Oct 19 '24 00:10 dpgeorge

This was fixed in 28136d837ab936324d46f2cbe50e686475f5c38c

Dec 08 '25 00:12 dpgeorge