block-loader icon indicating copy to clipboard operation
block-loader copied to clipboard

Publish latest dependency update

Open davidwebca opened this issue 4 years ago • 3 comments

Hi! Sorry to bother you, but it seems like the latest addition of Micropackage\Filesystem\Filesystem slipped into the code, but not in the composer.json file (maybe a publishing issue with composer?) so that when I installed the package, it didn't install Micropackage\Filesystem\Filesystem. To fix the issue, I had to install it manually even though it seems like you added it as a dependency lately.

Here's the composer.json file of the package that got installed on my end

{
	"name": "micropackage/block-loader",
	"version": "1.0.3",
	"description": "Block Loader - automatic Gutenberg blocks from template files.",
	"license": "GPL-3.0-or-later",
	"authors": [
		{
			"name": "Jakub Mikita",
			"email": "[email protected]"
		},
    {
      "name": "Wojtek Szałkiewicz",
      "email": "[email protected]"
    }
	],
	"scripts": {
		"phpcs": "phpcs",
		"phpcbf": "phpcbf"
	},
	"require": {
		"php": ">=5.6",
		"micropackage/singleton": "^1.1",
		"micropackage/dochooks": "^1.0"
	},
	"require-dev": {
		"dealerdirect/phpcodesniffer-composer-installer": "^0.5.0",
		"phpcompatibility/php-compatibility": "^9.1",
		"wp-coding-standards/wpcs": "^2.0"
	},
	"autoload": {
		"psr-4" : {
			"Micropackage\\BlockLoader\\" : "src"
		}
	}
}

compared to what I can see in the repo right now

{
	"name": "micropackage/block-loader",
	"version": "1.0.3",
	"description": "Block Loader - automatic Gutenberg blocks from template files.",
	"license": "GPL-3.0-or-later",
	"authors": [
		{
			"name": "Jakub Mikita",
			"email": "[email protected]"
		},
    {
      "name": "Wojtek Szałkiewicz",
      "email": "[email protected]"
    }
	],
	"scripts": {
		"phpcs": "phpcs",
		"phpcbf": "phpcbf"
	},
	"require": {
		"php": ">=5.6",
		"micropackage/singleton": "^1.1",
		"micropackage/dochooks": "^1.0",
		"micropackage/filesystem": "^1.1"
	},
	"require-dev": {
		"dealerdirect/phpcodesniffer-composer-installer": "^0.5.0",
		"phpcompatibility/php-compatibility": "^9.1",
		"wp-coding-standards/wpcs": "^2.0"
	},
	"autoload": {
		"psr-4" : {
			"Micropackage\\BlockLoader\\" : "src"
		}
	}
}

davidwebca avatar Jan 26 '21 14:01 davidwebca

Thanks for the notice @davidwebca !

There's indeed 4 commits not published. We'll be working on this package within a few days and will push the update

jakubmikita avatar Jan 29 '21 06:01 jakubmikita

Hi again. Sorry to use this issue to start a conversation, but I was wondering what's your preferred / recommended way to enqueue assets through the dockblock. I'd like to avoid writing manually the full base url (/wp-content/themes/mytheme/blocks/assets/js/myblock.js). Somehow I expected the path to be prefixed automatically with get_template_directory_uri(). Is it something that's already supported but I'm just doing it wrong? If not, what do you think about adding it? 🤔

davidwebca avatar Feb 07 '21 16:02 davidwebca

@davidwebca that's a good idea, I created a separate issue.

jakubmikita avatar Feb 22 '21 10:02 jakubmikita