micronaut-views icon indicating copy to clipboard operation
micronaut-views copied to clipboard

Reactive Views Renderer Soy

Open sdelamo opened this issue 3 years ago • 4 comments

sdelamo avatar Aug 10 '21 11:08 sdelamo

@sgammon I have taken your PR https://github.com/micronaut-projects/micronaut-views/pull/34 updated to:

  • use Project Reactor instead of RxJava2
  • change the spacing to use 4 spaces instead of 2
  • use micronaut nullability annotations intead of javax annotations.

However, they are failing test. Not sure if you can check it out and let me know what am I missing?

sdelamo avatar Aug 10 '21 11:08 sdelamo

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: sdelamo
:x: sgammon
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Feb 07 '24 21:02 CLAassistant

@sdelamo I never got notified about this. I'd be happy to take a look.

sgammon avatar Feb 08 '24 18:02 sgammon

@sgammon master has changed a lot since. We will need to merge master into this PR. If you want to do another effort towards this, I will review it.

sdelamo avatar Feb 22 '24 06:02 sdelamo