micronaut-starter icon indicating copy to clipboard operation
micronaut-starter copied to clipboard

Add micronaut-json-schema feature.

Open wetted opened this issue 10 months ago • 6 comments

closes #2431

This needs to target 4.5.x once that branch is created

wetted avatar Apr 09 '24 19:04 wetted

ping @sdelamo Should this support all application types?

wetted avatar Apr 09 '24 21:04 wetted

ping @sdelamo Should this support all application types?

Yes.

sdelamo avatar Apr 10 '24 11:04 sdelamo

Create an extra feature to add json-schema-validation module to the test class path.

@sdelamo What kind of logic do you want for adding one and/or the other, or validating the presence of them?

  • [x] add json-schema-validator feature if not present when selecting json-schema feature?
  • [x] FeatureValidator to assert json-schema is present if json-schema-validator is selected?
  • [ ] something else?

Edit: I did what's checked. Can make changes if desired.

wetted avatar Apr 10 '24 16:04 wetted

CI is failing on :test-features:test because ThymeleafSpec generates a project with views-fieldset-tck, and the TCK test fails. I'll see if I can figure it out.

Edit: see #2435

wetted avatar Apr 11 '24 17:04 wetted

ping @sdelamo I merged the ThymeleafSpec fix and CI is green now. This should be GTG.

wetted avatar Apr 12 '24 16:04 wetted

ping @sdelamo I merged the ThymeleafSpec fix and CI is green now. This should be GTG.

Let's wait until we have a release of Micronaut JSON Schema.

sdelamo avatar Apr 18 '24 09:04 sdelamo