micronaut-grpc icon indicating copy to clipboard operation
micronaut-grpc copied to clipboard

Introduce Server Security JWT Support

Open brianwyka opened this issue 4 years ago • 12 comments

Main Changes

  • Introduce new grpc-server-security-jwt module
  • Add latest Micronaut Security version
  • Supports role based security, however does not support @Secured annotation at this point

I've added a serverSecurity.adoc to document its usage.

Other Changes

  • Update to latest Micronaut version
  • Parameterize Micronaut Discovery Client version

Closes #164

brianwyka avatar Feb 22 '21 17:02 brianwyka

Any feedback on this @jameskleeh @ilopmar @graemerocher ?

brianwyka avatar Mar 02 '21 19:03 brianwyka

@brianwyka Any updates on this?

StephanePaulus avatar May 20 '21 12:05 StephanePaulus

@StephanePaulus, waiting for feedback on design direction from Micronaut team. After that, happy to move forward with changes.

@jameskleeh, @graemerocher let me know if you have any recommendations based on my latest comments in this thread...

brianwyka avatar Jun 04 '21 16:06 brianwyka

@brianwyka I haven't forgot about this. I'll try to make it a priority next week

jameskleeh avatar Jun 04 '21 16:06 jameskleeh

Thanks @jameskleeh. Let me know what you need from me. Happy to do the implementation as much as possible.

brianwyka avatar Jun 04 '21 16:06 brianwyka

@graemerocher @sdelamo @brianwyka This looks very useful feature, I have an interest in it for one of my projects. I think it can be nice to have it in the next major release. If needs any help with this PR, I can help to finish all work here.

donbeave avatar Nov 03 '22 09:11 donbeave

@donbeave this would be a great contribution, from my understanding it requires changes on the Micronaut Security side. /cc @sdelamo

graemerocher avatar Nov 03 '22 10:11 graemerocher

@donbeave this would be a great contribution, from my understanding it requires changes on the Micronaut Security side. /cc @sdelamo

We plan to decouple micronaut security from HttpRequest as much as possible in the next mayor version of Micronaut Security.

sdelamo avatar Nov 03 '22 11:11 sdelamo

@donbeave this would be a great contribution, from my understanding it requires changes on the Micronaut Security side. /cc @sdelamo

We plan to decouple micronaut security from HttpRequest as much as possible in the next mayor version of Micronaut Security.

@sdelamo maybe it's better for me to help you with decoupling first, as I'm using micronaut-security in GraphQL API, and it's not enough flexible, because it was designed around REST use cases. So if you need any help there, please let me know how you see that refactoring.

donbeave avatar Nov 03 '22 11:11 donbeave

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Feb 07 '24 21:02 CLAassistant

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Feb 07 '24 21:02 CLAassistant

@donbeave this would be a great contribution, from my understanding it requires changes on the Micronaut Security side. /cc @sdelamo

We plan to decouple micronaut security from HttpRequest as much as possible in the next mayor version of Micronaut Security.

@sdelamo maybe it's better for me to help you with decoupling first, as I'm using micronaut-security in GraphQL API, and it's not enough flexible, because it was designed around REST use cases. So if you need any help there, please let me know how you see that refactoring.

@donbeave Any help is welcome. We decoupled Micronaut Security almost completely from HTTP request. It is just the oauth2 module which is pending.

sdelamo avatar Feb 13 '24 08:02 sdelamo