micronaut-core icon indicating copy to clipboard operation
micronaut-core copied to clipboard

test: Add test "JsonAnyGetter JsonAnySetter (de-)serialization" to simplify resolution of the issue

Open UltimaPhoenix opened this issue 4 years ago • 5 comments

JsonAnyGetter and JsonAnySetter doesn't work when @Introspected annotation is declared. Making this test pass will allow anyone that makes extensive use of JsonAnyGetter-Setter feature to use reflection-free jackson.

Sorry for not implementing the fix I was short on time, by the way I think i identified the right classes where the fix should be implemented that are:

  • BeanIntrospectionModule.BeanIntrospectionDeserializerModifier method updateBuilder
  • BeanIntrospectionModule.BeanIntrospectionPropertyWriter

I think that the updateBuilder method needs to be refactored to improve maintainability.

UltimaPhoenix avatar Jan 17 '21 11:01 UltimaPhoenix

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jan 17 '21 11:01 CLAassistant

Can you change the branch you wish to merge this into? Should be one of the release branches (2.2.x, 2.3.x etc.)

graemerocher avatar Jan 18 '21 08:01 graemerocher

@UltimaPhoenix It seems as if you created a branch from a dependency-update branch. You'll need to rebase to 2.2.x

jameskleeh avatar Jan 19 '21 17:01 jameskleeh

@jameskleeh I've done.

UltimaPhoenix avatar Jan 20 '21 09:01 UltimaPhoenix

@graemerocher Is it ok? Do you prefer that I rebase it to 2.4.x?

UltimaPhoenix avatar Apr 13 '21 18:04 UltimaPhoenix