micronaut-core icon indicating copy to clipboard operation
micronaut-core copied to clipboard

Remove warning about Logbook bug

Open msdousti opened this issue 1 year ago • 4 comments

The official documentation mentions a major bug for Logbook:

image

It refers to this issue on the Logbook project, which has been fixed by this PR, and integrated into Logbook 3.1.0 on May 19, 2023.

As such, I'd like to suggest removing this waning from the documentation. Thanks!

msdousti avatar Nov 14 '23 17:11 msdousti

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

:white_check_mark: sdelamo
:white_check_mark: yawkat
:x: msdousti
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Nov 14 '23 17:11 CLAassistant

Test def 'h2c do not upgrade fails after upgrading to the latest logbook. @yawkat could you check it out?

sdelamo avatar Nov 24 '23 06:11 sdelamo

ive merged 4.2.x and now the logbook test suite tests fail

yawkat avatar Dec 06 '23 13:12 yawkat

The h2c do not upgrade test is failing because of these lines:

https://github.com/micronaut-projects/micronaut-core/blob/0530ff704695dedee4d614f2e6cb2e055a6128dc/test-suite/src/test/groovy/io/micronaut/docs/netty/LogbookNettyServerCustomizerSpec.groovy#L338-L339

As explained in the description of the PR, with new Logbook version (3.1 onwards), this bug is resolved, so the "second" bar should now be visible in the logs. I'll adapt the test.

For some other reason, another test tls alpn http 2 started to fail after merging 4.2.x onto this branch. I bumbed Logbook version on 4.2.x itself and the test passed. ~~A bit strange...~~

PS The test tls alpn http 2 failed because of the @Requires added in 4fefb40. For the moment, "fixed" by removing it. Please see 6920568857a90b872e7c201f5c83497dd6970ada.

msdousti avatar Dec 06 '23 16:12 msdousti