micrometer icon indicating copy to clipboard operation
micrometer copied to clipboard

Published 20 hours ago • verified publisher icon micrometer-metrics

Add Observed Tomcat Valve

Open marcingrzejszczak opened this issue 1 year ago • 4 comments

Example here https://github.com/micrometer-metrics/micrometer-samples/blob/4f9a6cd9d1c12fa19ec79a49766cce6afccd5ce2/micrometer-samples-boot3-web/src/main/java/io/micrometer/boot3/samples/web/ManualConfiguration.java#L41-L96

marcingrzejszczak avatar Apr 20 '23 08:04 marcingrzejszczak

@marcingrzejszczak Do you have a solution to this?

fischermatte avatar Feb 21 '24 12:02 fischermatte

What are you seeking a solution for? Have you checked the code in the description of this PR?

jonatan-ivanov avatar Feb 21 '24 16:02 jonatan-ivanov

Sry, maybe I misunderstood something. I am coming from this issue (Exceptions are not logged with span-id/trace-id with latest spring boot). There @bclozel mentioned this

"You can follow https://github.com/micrometer-metrics/micrometer/issues/3777 if you'd like to instrument your application at a lower level with Tomcat."

Now it looks like this PR is still open for some reason. Do you see any chance that exceptions logged from tomcat itself can be enhanced with a trace-id/span-id?

fischermatte avatar Feb 21 '24 21:02 fischermatte