micrometer icon indicating copy to clipboard operation
micrometer copied to clipboard

Micrometer registry appdynamics

Open rjmveloso opened this issue 2 years ago • 5 comments

This PR contributes with a registry for AppDynamics #575

rjmveloso avatar Oct 08 '22 11:10 rjmveloso

:warning: 10 God Classes were detected by Lift in this project. Visit the Lift web console for more details.

sonatype-lift[bot] avatar Oct 08 '22 11:10 sonatype-lift[bot]

CircleCi is failing because there is no baseline for AppDynamics yet.

rjmveloso avatar Oct 09 '22 15:10 rjmveloso

@rjmveloso You can disable that check: see here

jonatan-ivanov avatar Oct 11 '22 21:10 jonatan-ivanov

Thank you @jonatan-ivanov, I ran it locally with -PcompatibleVersion=SKIP. I believe this would be removed from the condition after a first release of the module.

rjmveloso avatar Oct 13 '22 08:10 rjmveloso

@rjmveloso You can disable that check: see here

Think your suggestion and my previous observation relates with the issue https://github.com/micrometer-metrics/micrometer/issues/3486

rjmveloso avatar Oct 13 '22 13:10 rjmveloso

It seems Gradle Plugin Portal was facing some outages leading to the following problem (version not in maven central):

Could not find org.ajoberstar.grgit:grgit-core:4.0.2.
     Searched in the following locations:
       - https://repo.maven.apache.org/maven2/org/ajoberstar/grgit/grgit-core/4.0.2/grgit-core-4.0.2.pom
       - https://plugins.gradle.org/m2/org/ajoberstar/grgit/grgit-core/4.0.2/grgit-core-4.0.2.pom

It is possible to force a rerun of the actions and also if possible to have a core review?

rjmveloso avatar Nov 09 '22 10:11 rjmveloso

Any change of this PR be reviewed?

rjmveloso avatar Nov 28 '22 15:11 rjmveloso

As far as I can tell, all tag info is dropped from publishing. Is that correct? That's a lot of valuable information lost. I'm not sure we would want to support that in the Micrometer repo. Does AppDynamics not support dimensions (tags) on metrics?

You are correct. There is no direct way to publish tags with AppDynamics agent. Maybe a solutions would be to create sub-paths for any Custom Metric for each tag, but in the end it will be just replicated metrics with the same values. I will investigate it further.

rjmveloso avatar Dec 25 '23 13:12 rjmveloso

If you would like us to look at this PR, please provide the requested information. If the information is not provided within the next 7 days this PR will be closed.

github-actions[bot] avatar Jan 07 '24 01:01 github-actions[bot]

As far as I can tell, all tag info is dropped from publishing. Is that correct? That's a lot of valuable information lost. I'm not sure we would want to support that in the Micrometer repo. Does AppDynamics not support dimensions (tags) on metrics?

@shakuzen There is no support for tags/dimensions on AppDynamics. I cannot provide further support because I don't have access to appd anymore. If AppDynamics have support for OpenTelemetry (as read in some thread related with the subject) I would suggest anyone interested to go for it and use otlp micrometer exporter .

rjmveloso avatar Jan 13 '24 10:01 rjmveloso

If you would like us to look at this PR, please provide the requested information. If the information is not provided within the next 7 days this PR will be closed.

github-actions[bot] avatar Jan 21 '24 01:01 github-actions[bot]

Closing due to lack of requested feedback. If you would like us to look at this, please provide the requested information and we will re-open.

github-actions[bot] avatar Jan 29 '24 01:01 github-actions[bot]