micrometer
micrometer copied to clipboard
Micrometer registry appdynamics
This PR contributes with a registry for AppDynamics #575
:warning: 10 God Classes were detected by Lift in this project. Visit the Lift web console for more details.
CircleCi is failing because there is no baseline for AppDynamics yet.
@rjmveloso You can disable that check: see here
Thank you @jonatan-ivanov, I ran it locally with -PcompatibleVersion=SKIP
.
I believe this would be removed from the condition after a first release of the module.
@rjmveloso You can disable that check: see here
Think your suggestion and my previous observation relates with the issue https://github.com/micrometer-metrics/micrometer/issues/3486
It seems Gradle Plugin Portal was facing some outages leading to the following problem (version not in maven central):
Could not find org.ajoberstar.grgit:grgit-core:4.0.2.
Searched in the following locations:
- https://repo.maven.apache.org/maven2/org/ajoberstar/grgit/grgit-core/4.0.2/grgit-core-4.0.2.pom
- https://plugins.gradle.org/m2/org/ajoberstar/grgit/grgit-core/4.0.2/grgit-core-4.0.2.pom
It is possible to force a rerun of the actions and also if possible to have a core review?
Any change of this PR be reviewed?
As far as I can tell, all tag info is dropped from publishing. Is that correct? That's a lot of valuable information lost. I'm not sure we would want to support that in the Micrometer repo. Does AppDynamics not support dimensions (tags) on metrics?
You are correct. There is no direct way to publish tags with AppDynamics agent. Maybe a solutions would be to create sub-paths for any Custom Metric for each tag, but in the end it will be just replicated metrics with the same values. I will investigate it further.
If you would like us to look at this PR, please provide the requested information. If the information is not provided within the next 7 days this PR will be closed.
As far as I can tell, all tag info is dropped from publishing. Is that correct? That's a lot of valuable information lost. I'm not sure we would want to support that in the Micrometer repo. Does AppDynamics not support dimensions (tags) on metrics?
@shakuzen There is no support for tags/dimensions on AppDynamics. I cannot provide further support because I don't have access to appd anymore. If AppDynamics have support for OpenTelemetry (as read in some thread related with the subject) I would suggest anyone interested to go for it and use otlp micrometer exporter .
If you would like us to look at this PR, please provide the requested information. If the information is not provided within the next 7 days this PR will be closed.
Closing due to lack of requested feedback. If you would like us to look at this, please provide the requested information and we will re-open.