micrometer-docs icon indicating copy to clipboard operation
micrometer-docs copied to clipboard

Update New Relic docs

Open breedx-nr opened this issue 4 years ago • 6 comments

Hi. We'd like to see about updating these older docs to more proactively point to our dimensional metrics based registry. Would love to know what you think and what else we can do to help get these changed.

Thanks!

breedx-nr avatar Jul 17 '20 22:07 breedx-nr

Just wanted to leave a gentle poke to see if anybody might be able to look at this. Thanks.

breedx-nr avatar Jul 27 '20 23:07 breedx-nr

Bumping again. Would it be possible to get an estimate on when we might get eyes on this? 🙏 🙇‍♂️

breedx-nr avatar Aug 03 '20 17:08 breedx-nr

Any updates? Critiques? Concerns? Feedback? 🍰

breedx-nr avatar Aug 10 '20 18:08 breedx-nr

Squash down to one commit? @shakuzen and @jkschneider .. should the existing micrometer new relic extension be deprecated (and then have that reflected in the docs here?)

ebullient avatar Aug 12 '20 16:08 ebullient

Thank you for taking a look at this!

Re: deprecating the existing registry -- there was some discussion a while back about New Relic possibly hosting it. That discussion is here: https://github.com/newrelic/micrometer-registry-newrelic/issues/46. I would love for us to collectively come to an agreement on that point. The primary concern is that users might be confused about which one to use...so having a primary recommended solution is best.

breedx-nr avatar Aug 12 '20 18:08 breedx-nr

Thanks for the pull request. Sorry for the delay in responding here. I would like to have some response to https://github.com/newrelic/micrometer-registry-newrelic/issues/46#issuecomment-598586618 before making these kinds of changes to our docs. I am in support of getting to a point of there being one New Relic registry implementation that works best for users. I am concerned about making such a transition as smooth as possible, and I think that's what needs to be worked out before we officially tell users to stop using something.

shakuzen avatar Aug 13 '20 01:08 shakuzen

I'm closing this since we moved the docs to their respective projects and https://github.com/newrelic/micrometer-registry-newrelic is deprecated wile Micrometer's New Relic registry is still supported.

jonatan-ivanov avatar Jan 23 '24 22:01 jonatan-ivanov