GmsCore icon indicating copy to clipboard operation
GmsCore copied to clipboard

Add Turkish (TR) strings

Open ysfchn opened this issue 1 year ago • 6 comments

~~This PR adds Turkish (language code is tr) strings for all packages from what I could find, except play-services-nearby (I had no time to also translate that but plan to do that later.)~~

  • ~~play-services-ads-identifier~~
  • ~~play-services-auth-api-phone~~
  • ~~play-services-base~~
  • ~~play-services-core~~
  • ~~play-services-droidguard~~
  • ~~play-services-fido~~
  • ~~play-services-location~~
  • ~~play-services-oss-licenses~~
  • ~~vending-app~~

Edit: Updated PR with only including strings for play-services-core/microg-ui-tools package, I've translated other packages in Weblate since they are already available there.

I've kept copyright notices as-is, and I noticed few of strings a wrapped with " (quotation) character, I assume it is written to escape ' (apostrophe), so I added backslash in front of each ' to avoid wrapping the whole string with " instead to make it consistent with other strings. I'm not sure if I have to do something else to make microG display in Turkish but after taking a look at Android documentation, I guess adding a new folder values-tr is enough.

Thanks for making microG by the way, I cannot express in words how much it has helped me.

ysfchn avatar Jul 21 '24 22:07 ysfchn

You might wanna try and import this to Weblate https://hosted.weblate.org/projects/microg/#languages, worth linking because I don't think it has been linked anywhere even though it is used It causes less issues that way with merging and so, though to be fair it seems turkish does not have any files so I don't think there would be a merge conflict here, but after this is merged it should show up just fine there as well.

Well, anyhow it is nice to have since you can set up notifications for new strings and such;

lucasmz-dev avatar Jul 23 '24 00:07 lucasmz-dev

https://github.com/microg/GmsCore/tree/master/play-services-core/microg-ui-tools/src/main/res

This one is significant and you may wanna do, it isn't on Weblate and you have to open a PR for it atm, so might as well take advantage

It is basically the entire portion of the Self-Check feature and a few other things

lucasmz-dev avatar Jul 23 '24 00:07 lucasmz-dev

It causes less issues that way with merging and so, though to be fair it seems turkish does not have any files so I don't think there would be a merge conflict here, but after this is merged it should show up just fine there as well.

I didn't know there was a Weblate project for MicroG until I created this PR, but it seems that Weblate doesn't include a Turkish language yet, so even if I wanted to, it is not possible to contribute on Weblate for Turkish.

This one is significant and you may wanna do, it isn't on Weblate and you have to open a PR for it atm, so might as well take advantage

Huh, I somehow missed that file, thanks, will push a new commit for it soon. Edit: Done.

ysfchn avatar Jul 23 '24 08:07 ysfchn

I didn't know there was a Weblate project for MicroG until I created this PR, but it seems that Weblate doesn't include a Turkish language yet, so even if I wanted to, it is not possible to contribute on Weblate for Turkish.

Yeah, it isn't linked anywhere yet except for commits 😵‍💫 If you wanted to add it, you just have to have an account, then add Turkish as one of the languages you can translate to, then you should be able to add that language.

Anyway, good job :P

lucasmz-dev avatar Jul 23 '24 18:07 lucasmz-dev

I somehow messed up the commit history while pulling the latest commits, everything should be fine now. And I noticed missing escapes, so I fixed these problematic strings.

ysfchn avatar Aug 08 '24 21:08 ysfchn

@mar-v-in just ui tools now

lucasmz-dev avatar Dec 16 '24 03:12 lucasmz-dev