mf2py icon indicating copy to clipboard operation
mf2py copied to clipboard

update setup.py and fix #95: don't add slashes to void elements

Open sknebel opened this issue 7 years ago • 5 comments

combined with setup.py since it relies on features new to BS4.

sknebel avatar Oct 02 '18 16:10 sknebel

concern with this: might break granary: https://github.com/microformats/mf2py/issues/95#issuecomment-427440995

sknebel avatar Oct 05 '18 18:10 sknebel

per further discussion in #95, granary can handle this by changing to html format in the Atom feeds

sknebel avatar Nov 07 '18 19:11 sknebel

looks good to me. Might want to add some tests for this so that we can track any future changes to the code base.

kartikprabhu avatar May 22 '20 00:05 kartikprabhu

Is there a reason why the MinimalHtmlFormatter uses class variables for configuration instead of instance variables assigned on __init__? And shouldn’t the subclass use __init__ regardless?

fluffy-critter avatar May 23 '20 16:05 fluffy-critter

Also: From the BeautifulSoup documentation it looks like they already provide an HTML5 formatter which you get by passing the string"html5" to the formatter parameter

fluffy-critter avatar May 23 '20 16:05 fluffy-critter