nmdc-schema icon indicating copy to clipboard operation
nmdc-schema copied to clipboard

string vs enumeration for GOLD pathway slots

Open aclum opened this issue 2 years ago • 4 comments

I noticed that for GOLD pathway slots https://microbiomedata.github.io/submission-schema/gold_path_field/ the range is an enumeration in the submission portal and a string in nmdc-schema. Since most of the data will come in from ingest scripts which bypass the submission schema we should revisit making the validation consistent. Reddy has noted that they release new pathways as needed so we may have problems keeping in sync.

@turbomam @pkalita-lbl @mslarae13

aclum avatar Sep 12 '23 00:09 aclum

The enumeration on the submission portal is meant to help / guide people. However, I see it doesn't validate if you type in just any text. that one requires it comes from the enumeration. It probably should.

Curious on other peoples thoughts.

mslarae13 avatar Sep 21 '23 00:09 mslarae13

I think if populated both the submission schema and nmdc schema should use validate against the same enumeration and we need a process to keep this in sync with what GOLD has. Not sure how to do this w/o a release schedule from GOLD, perhaps we update quarterly.

aclum avatar Sep 21 '23 00:09 aclum

++ Can we prevent allowing people to type into this slot? Currently, you can type something into a lower level, but if you haven't selected anything in the 'upper' level of the hierarchy, it doesn't validate

See submission 6f99e199-c6c3-4d79-aac6-57446fde26f4

Uploading Screenshot 2023-12-27 at 11.55.59 AM.png…

mslarae13 avatar Dec 27 '23 19:12 mslarae13

Closing, this seems fine since @pkalita-lbl implemented pulling current GOLD pathway terms into the submission schema.

aclum avatar Feb 28 '25 22:02 aclum